Version.hh is supplied by :openroad_version; don't duplicate in :ord#10436
Open
hzeller wants to merge 2 commits into
Open
Version.hh is supplied by :openroad_version; don't duplicate in :ord#10436hzeller wants to merge 2 commits into
hzeller wants to merge 2 commits into
Conversation
Signed-off-by: Henner Zeller <h.zeller@acm.org>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the BUILD.bazel file by removing include/ord/Version.hh from the :ord library's headers and adding an includes path to the :openroad_version target. The review feedback suggests that the :ord library should explicitly depend on :openroad_version to ensure header availability and satisfy Bazel layering checks. Additionally, there is a suggestion to expand the includes list for :openroad_version to support flat include paths for the version header.
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
The `-Iinclude/ord` was not needed and unnecessarily allowed these headers to be included without any prefix. Signed-off-by: Henner Zeller <h.zeller@acm.org>
Contributor
|
clang-tidy review says "All clean, LGTM! 👍" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.